[HS3][RF] I/O for RooWrapperPdf and RooExtendPdf#22647
Open
cburgard wants to merge 2 commits into
Open
Conversation
guitargeek
reviewed
Jun 17, 2026
| node["function"] << funcProxy->absArg()->GetName(); | ||
|
|
||
| if (pdf->selfNormalized()) | ||
| node["misc"]["ROOT_internal"]["selfNormalized"] << true; |
Contributor
There was a problem hiding this comment.
I thought everything outside the schema should go inside the global "misc" node somehow, just like the string attributes? This is the first time that we add a "misc" field to a distribution. Does the standard mention that "misc" is a reserved key for miscellaneous info also in that context?
Contributor
Author
There was a problem hiding this comment.
You are absolutely right. The initial draft of this code was AI-generated, and I overlooked this bug. Thanks for catching it! I just pushed the fix.
Test Results 22 files 22 suites 3d 12h 37m 21s ⏱️ Results for commit 8e45bb6. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added I/O for roowrapperpdf and changed extendpdf I/O to be compliant with hs3
This Pull request:
adds JSONIO for the two classes mentioned
Changes or fixes:
Checklist:
This PR fixes #